Added docker container for quick review of an application. #6
Conversation
|
Can you confirm that the docker instance still works with https://github.com/vincentcox/StaCoAn/tree/develop? Build is passing, so if docker works for you, it will be merged to master. |
|
I update the docker setup with a drag and drop interface. It's now pushed to develop. |
|
Hi ! I just took a look at it. The docker now is much much smaller, but here: https://github.com/vincentcox/StaCoAn/blob/develop/src/helpers/server.py#L442 You have hardcoded a port (8080) for the report to be opened, but by default, the web server is running in port 8000, so when you click on it, you get an error, as the server is not running in that port. Am I missing something here? Feel free to add me wherever you want. Glad I helped a little ! |
|
Hi there,
You were correct!
Somehow my latest commit didn’t get trough.
Now it should work, can you try again?
I will add your twitter handle in the next commit! 🙌
… On 26 Feb 2018, at 01:14, Borja Berastegui ***@***.***> wrote:
Hi ! I just took a look at it.
The docker now is much much smaller, but here: https://github.com/vincentcox/StaCoAn/blob/develop/src/helpers/server.py#L442
You have hardcoded a port (8080) for the report to be opened, but by default, the web server is running in port 8000, so when you click on it, you get an error, as the server is not running in that port.
Am I missing something here?
Feel free to add me wherever you want. Glad I helped a little !
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
When cloning the develop branch I still get the link to the port 8080, and the name of the report location is not ok neither (check the Link generated: Link corrected: |
|
Damn, will look at it this evening. Thanks for testing it! |
|
Just to double check, did you changed https://github.com/vincentcox/StaCoAn/blob/develop/docker/Dockerfile#L19 to |
|
Yup: The HTML I end up with is like this:
|
|
b2099e3
|
|
@vincentcox Then, you might want to |
* Re-adapted the docker to the develop branch (#26) Many thanks to @BBerastegui, I am not very familiar with docker and this certainly was very useful to add to this project. * Some minor improvements (#31) * Automaticly fix jadx file permissions * Bugfix: Open browser on macOS Browser did not open automatically on macOS. * Show a summary at the end You can add more statistics here, so that the user has a nice summary. * Reduce cmdline output by overwriting progress line * Usage of enumerate instead of manual index mgmt (#32) * Updated readme file, Acknowledgments * Implement arguments (#33) stacoan.py [-h] [-p PATH [PATH ...]] [--disable-browser] [--log-all | --log-errors | --log-warnings] * make a server option in StaCoAn, for reporting and drag and drop interface * Updated readme and docker file for parameters * seperate folder for each project * travis file update * Filetype check on the server (ipa, apk) (#34) * Thread handling and server optimalisations * Update gitignore * Fix typo * fix pyinstaller issue * Fix javascript punctuation issue #6 (comment) * added authors to README.TXT
* Re-adapted the docker to the develop branch (#26) Many thanks to @BBerastegui, I am not very familiar with docker and this certainly was very useful to add to this project. * Some minor improvements (#31) * Automaticly fix jadx file permissions * Bugfix: Open browser on macOS Browser did not open automatically on macOS. * Show a summary at the end You can add more statistics here, so that the user has a nice summary. * Reduce cmdline output by overwriting progress line * Usage of enumerate instead of manual index mgmt (#32) * Updated readme file, Acknowledgments * Implement arguments (#33) stacoan.py [-h] [-p PATH [PATH ...]] [--disable-browser] [--log-all | --log-errors | --log-warnings] * make a server option in StaCoAn, for reporting and drag and drop interface * Updated readme and docker file for parameters * seperate folder for each project * travis file update * Filetype check on the server (ipa, apk) (#34) * Thread handling and server optimalisations * Update gitignore * Fix typo * fix pyinstaller issue * Fix javascript punctuation issue #6 (comment) * added authors to README.TXT * Fix modules builder
No description provided.